Chore: Move getUserRoles to service and add cache#22345
Merged
sampaiodiego merged 1 commit intodevelopfrom Jun 16, 2021
Merged
Conversation
KevLehman
reviewed
Jun 14, 2021
| }, | ||
| }; | ||
|
|
||
| const users = await this.Users.findUsersInRoles(roleIds, null, options).toArray(); |
Member
There was a problem hiding this comment.
If there happens to be a role all users have, this query may return the whole list of users (which can be quite big). Any plans to paginate this? 👀
Member
Author
There was a problem hiding this comment.
I see 🤔 I didn't change the previous behavior though.. maybe we should deprecate this method 🤔
Member
There was a problem hiding this comment.
Yeah 🤔 that would be a good thing, other than that, the code looks good, so I don't know if I should approve and after that create a task to deprecate this one 👀
Member
Author
There was a problem hiding this comment.
Agreed, I'll create a task to deprecate this 👍
ggazzo
approved these changes
Jun 15, 2021
Merged
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Moving this code to a service to make it re-usable and also adding a small cache since this info doesn't change very often.
Issue(s)
Steps to test or reproduce
Further comments